Fix RTD and modernize workflows (#151)

* Fix RTD and modernize workflows

* DOC: extra requirements for docs

* RTD: Disable fail on warnings

.github/workflows/ci_workflows.yml

@@ -23,7 +23,7 @@ jobs:
   #  runs-on: ubuntu-latest
   #  steps:
   #  - name: Checkout code
-  #    uses: actions/checkout@v3
+  #    uses: actions/checkout@v4
   #    with:
   #      fetch-depth: 0
   #  - name: Set up Python
@@ -39,7 +39,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Set up Python
@@ -61,7 +61,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Set up Python
@@ -80,7 +80,7 @@ jobs:
     needs: [pep_and_audit, initial_tests]
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Set up Python
@@ -90,7 +90,7 @@ jobs:
     - name: Install and build
       run: |
         python -m pip install --upgrade pip wheel setuptools
-        python -m pip install git+https://github.com/astropy/astropy.git@main#egg=astropy
+        python -m pip install --extra-index-url https://pypi.anaconda.org/astropy/simple astropy>=0.0.dev0 --pre --upgrade
         python -m pip install -e .[test]
     - name: Test with dev deps
       run: pytest
@@ -100,7 +100,7 @@ jobs:
     needs: [pep_and_audit, initial_tests]
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Set up Python
@@ -120,15 +120,15 @@ jobs:
     needs: [pep_and_audit, initial_tests]
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
         python-version: '3.x'
     - name: Install and build
       run: |
-        python -m pip install --upgrade pip wheel setuptools sphinx
-        python -m pip install -e .
+        python -m pip install --upgrade pip wheel setuptools
+        python -m pip install -e .[docs]
     - name: Docs link check
       run: |
         cd doc

.github/workflows/codeql-analysis.yml

@@ -37,7 +37,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/predeps_workflow.yml

@@ -20,7 +20,7 @@ jobs:
         #os: [ubuntu-latest, windows-latest, macos-latest]
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
     - name: Set up Python

.readthedocs.yml

@@ -5,21 +5,23 @@
 version: 2
 
 build:
-  os: ubuntu-20.04
+  os: ubuntu-22.04
   apt_packages:
     - graphviz
   tools:
-    python: "3.9"
+    python: "3.11"
 
 sphinx:
   builder: html
   configuration: doc/source/conf.py
-  fail_on_warning: true
+  fail_on_warning: false
 
 python:
   install:
     - method: pip
       path: .
+      extra_requirements:
+        - docs
 
 # Don't build any extra formats
 formats: []

doc/source/conf.py

@@ -24,7 +24,7 @@
 # coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
 extensions = ['sphinx.ext.autodoc',
               'sphinx.ext.imgmath',
-              'sphinx.ext.napoleon',
+              'numpydoc',
               'sphinx.ext.intersphinx',
               'sphinx.ext.autosummary',
               'sphinx.ext.doctest']

setup.cfg

@@ -39,6 +39,10 @@ test =
     pytest
     pytest-astropy-header
     pytest-doctestplus
+docs =
+    sphinx<7
+    numpydoc
+    sphinx_rtd_theme
 
 [options.package_data]
 stsci.tools.tests = data/*.*