Fix bug when setting meta.background in SkyMatchStep. #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairanteodoro
added
bug
mairanteodoro
requested review from
bmorris3 and
schlafly
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 117 117
Lines 8086 8086
=======================================
Hits 6383 6383
Misses 1703 1703
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmorris3
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good, it was time for this update. Thanks @mairanteodoro!
mairanteodoro
force-pushed
the
skymatch_bugfix
branch
2 times, most recently
from
c51a07f
to
ebc5596
Compare
6 tasks
mairanteodoro
force-pushed
the
skymatch_bugfix
branch
from
ebc5596
to
d01bf65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-837
This PR addresses a bug in
SkyMatchStepthat was causing meta.background.subtracted to always be set toNoneinstead ofTrue/False, which was preventingResampleStepfrom properly using the sky level as determined bySkyMatchStepand set inmeta.background.level.The changes to the code also required some refactoring to the unit tests.
The code changes in this PR are also related to this old issue: spacetelescope/rad#247
Regression tests
The only failed test has nothing to do with the changes in this PR.
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/764/https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/770/
Checklist
CHANGES.rstunder the corresponding subsection