Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services for Ocean Optics spectrometers #172

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

johanmazoyer
Copy link
Collaborator

Official API exists in C by Ocean optics called seabreeze: https://www.oceaninsight.com/globalassets/catalog-blocks-and-images/software-downloads-installers/javadocs-api/seabreeze/html/index.html

Good python package wrapping this API seems to be python-seabreeze
https://pypi.org/project/seabreeze/
https://github.com/ap--/python-seabreeze

Address issue in ivalaginja/thd-controls#143

@johanmazoyer johanmazoyer self-assigned this Apr 5, 2024
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicely coming into shape! It looks to me like you have made the decision to not have the spectrometer run a continuous acquisition like a camera, and instead to wait for a sent acquisition command like for example the PLP power source or the DM. Is that correct? In this case, I have left you a comment to help you straighten out the main() loop. If I am interpreting this wrong though, do let me know and I will point you more in the direction of continuous acquisition loops like the cameras.

Also, could you maybe create a twin PR in https://github.com/ivalaginja/thd-controls with a new service entry for the spectrometer, so that I know which config entries to match and what that looks like?

The rest are just some minor comments that you will need to address before merging anyway and that are not critical to the service.

@ivalaginja ivalaginja added hardware Integrate new hardware collaborators Worked on by external collaborator. Might need some extra help on code integration. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaborators Worked on by external collaborator. Might need some extra help on code integration. hardware Integrate new hardware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants