Add base classes for cameras and DMs #131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivalaginja This might be interesting for you. I mainly want to know if the Andor camera is compatible with this base class. |
|
@ehpor this looks totally compatible with our Andor Neo. I don't think we'd have some of the parameters to read from the config, like the gain, but we can keep those properties unimplemented and the value in the configfile at None or empty so that it just sets the default value, considering it would never use it anyway. |
ehpor
force-pushed
the
bmc_dm_refactor
branch
from
4e9711c
to
7309f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP but I might want some feedback soon.
These base services generalize much of the functionality that is currently duplicated between cameras and DMs. This simplifies their implementation and makes fixing bugs in ROI flips and rotations, DM channel updates, etc. much easier in the future.