Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default char to monospaced arrow #722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change default char to monospaced arrow #722

wants to merge 1 commit into from

Conversation

sunknudsen
Copy link

Description

SPACESHIP_CHAR_SYMBOL was set to "Heavy Round-Tipped Rightwards" unicode U+279C character which broke monospacing. Replaced "Heavy Round-Tipped Rightwards" character by "Rightwards Arrow".

Screenshot

Screen Shot 2019-08-28 at 7 13 31 PM

`SPACESHIP_CHAR_SYMBOL` was set to "Heavy Round-Tipped Rightwards" unicode `U+279C` character which broke monospacing. Replaced "Heavy Round-Tipped Rightwards" character by "Rightwards Arrow".
@salmanulfarzy
Copy link
Member

I think it was a conscious choice by @denysdovhan

@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Aug 29, 2019
@sunknudsen
Copy link
Author

@salmanulfarzy Thanks for the follow up. I suspected the same, but found it odd that ~ and have the same width on all official screenshots and screen captures. I followed the guidelines of https://github.com/denysdovhan/spaceship-prompt/blob/master/docs/Troubleshooting.md#why-doesnt-my-prompt-look-like-the-preview. If the current arrow is the expected one, feel free to discard this PR. Thanks for the awesome zsh prompt btw!

@salmanulfarzy
Copy link
Member

Even though it's not monospace and I like the rounded arrow. Anyway I'll leave the decision on whether to switch character to @denysdovhan.

@salmanulfarzy salmanulfarzy changed the title Fixed #721 Change default char to monospaced arrow Aug 29, 2019
@denysdovhan
Copy link
Member

Rounded arrow just didn't look so sharp for me. However, if this causes real problems with displaying it correctly with monospaced fonts, then we may change it.

@sunknudsen
Copy link
Author

@denysdovhan On my MacBook Pro Retina (macOS Mojave), the only way I could achieve the look on https://github.com/denysdovhan/spaceship-prompt (monospaced tilde and arrow) was to set SPACESHIP_CHAR_SYMBOL="→ ". The default arrow didn’t play well with Fira Code on iTerm2. Anyhow, obviously a cosmetic "improvement". Have an amazing day!

@denysdovhan
Copy link
Member

@sunknudsen yeah, you're right. I use fira code and iterm and have the same issue. I didn't pay attention to it earlier.

Screen Shot 2019-09-05 at 10 56 35

@salmanulfarzy salmanulfarzy added the frozen Progress is temporarily frozen until resolving the specific issue. label Sep 20, 2019
@denysdovhan denysdovhan removed the frozen Progress is temporarily frozen until resolving the specific issue. label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

None yet

3 participants