Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dropbox segment #628

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added dropbox segment #628

wants to merge 4 commits into from

Conversation

TimothyEarley
Copy link

Description

Display the Dropbox status ("up to date", "syncing") when in the Dropbox directory using the standard dropbox-cli tool.

I use this because I tend to jump around in my file system and want a clear indication that I am in the Dropbox folder.

I am not sure about the icon. I have used one from nerd fonts which requires a compatible font.

Screenshot

screenshot

@maximbaz
Copy link
Contributor

maximbaz commented Feb 3, 2019

I use this because I tend to jump around in my file system and want a clear indication that I am in the Dropbox folder.

Just to clarify the purpose of this section, is ~/Dropbox string on your screenshot not a clear enough indication that you are in the Dropbox folder?

@TimothyEarley
Copy link
Author

Not always since I use the default setting of SPACESHIP_DIR_TRUNC=3 and have similar folder structures in my Dropbox and Documents.

denysdovhan
denysdovhan reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this PR is useful. I personally, see use-cases for this section. However, we need to make sure the dropbox icon will be shown correctly with other powerline fonts.

@denysdovhan denysdovhan added new-feature A PR that implement feature (section, specific behavior, etc). review-required labels May 13, 2019
@salmanulfarzy salmanulfarzy added the frozen Progress is temporarily frozen until resolving the specific issue. label Sep 20, 2019
@denysdovhan
Copy link
Member

@TimothyEarley can you rebase this section against the newest master?

@netlify
Copy link

netlify bot commented Oct 7, 2022 •
edited

✅ Deploy Preview for spaceship-prompt ready!

Name Link
🔨 Latest commit e95f25f
🔍 Latest deploy log https://app.netlify.com/sites/spaceship-prompt/deploys/634058be6460800009351ff8
😎 Deploy Preview https://deploy-preview-628--spaceship-prompt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TimothyEarley
Copy link
Author

@TimothyEarley can you rebase this section against the newest master?

Done! I've tried it out locally and it seems to work. Note though that I am currently not using the spaceship prompt.

P.S.: If this is more suited as an external section, anyone is welcome to take my code as a basis.

@denysdovhan denysdovhan removed the frozen Progress is temporarily frozen until resolving the specific issue. label Oct 31, 2022
@denysdovhan
Copy link
Member

Let's release it as an external section. @TimothyEarley would you mind creating a repo and releasing this as an external section?

Visit this page for more info: https://spaceship-prompt.sh/advanced/creating-section/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan left review comments

@maximbaz maximbaz Awaiting requested review from maximbaz

@salmanulfarzy salmanulfarzy Awaiting requested review from salmanulfarzy

At least 1 approving review is required to merge this pull request.

Assignees

@TimothyEarley TimothyEarley

Labels
new-feature A PR that implement feature (section, specific behavior, etc).
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TimothyEarley @maximbaz @denysdovhan @salmanulfarzy