fix: --short arg in kubectl cmd does not exist in later versions #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spaceship-prompt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
denysdovhan
reviewed
Apr 30, 2024
| @@ -31,7 +31,7 @@ spaceship_kubectl_version() { | |||
| [[ -z $kube_context ]] && return | |||
|
|
|||
| # if kubectl can't connect kubernetes cluster, kubernetes version section will be not shown | |||
| local kubectl_version=$(kubectl version --short 2>/dev/null | grep "Server Version" | sed 's/Server Version: \(.*\)/\1/') | |||
| local kubectl_version=$(kubectl version>/dev/null | grep "Server Version" | sed 's/Server Version: \(.*\)/\1/') | |||
There was a problem hiding this comment.
Does this work?
>/dev/null seems to be hushing everything, not just errors.
There was a problem hiding this comment.
It does work, on the newer version >1.28 though. Didn't test on lower ones.
The --short args is not required and actually removed hence why it broke on newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kubectl version --short is now the default since >=1.28, and the arg has been removed.
Screenshot
Please see: kubernetes/kubernetes#122455 (comment)