Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show docker section when using Orbstack #1376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Navrin
Copy link

@Navrin Navrin commented Aug 21, 2023

First time submitting a PR, modelled after #1101

Description

  • Fixes docker section from always showing when using Orbstack on macos.

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for spaceship-prompt ready!

Name Link
🔨 Latest commit 11f4fb1
🔍 Latest deploy log https://app.netlify.com/sites/spaceship-prompt/deploys/65a47524b3062900088bce79
😎 Deploy Preview https://deploy-preview-1376--spaceship-prompt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jean-humann
Copy link

@Navrin is possible to update the branch and @denysdovhan to review it please ?
Orbstack has a growing popularity and its a shame its not working properly with spaceship 👎

@Navrin
Copy link
Author

Navrin commented Jan 15, 2024

@Navrin is possible to update the branch and @denysdovhan to review it please ? Orbstack has a growing popularity and its a shame its not working properly with spaceship 👎

Had a git noob moment and rebased when I should have just merged, hence the force push on my own repo to reset the branch and merge instead. Does the sync/update look alright now though? I am assuming the actions I do on my own repo will not matter when merging the fork, but please do correct any misunderstandings I may have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants