feat: add support for R lang #1371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spaceship-prompt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Open
denysdovhan
requested changes
Jul 27, 2023
docs/sections/R.md
Outdated
| @@ -0,0 +1,25 @@ | |||
| # R (`R lang`) | |||
There was a problem hiding this comment.
Let's use a convention similar to V lang. We use vlang key in code to avoid confusion. Let's do the same for R lang. Please use rlang everywhere
Suggested change
| # R (`R lang`) | |
| # R (`rlang`) |
docs/sections/R.md
Outdated
| !!! info | ||
| [**R**](https://r-project.org) is a free software environment for statistical computing and graphics. | ||
|
|
||
| The `R` section displays the R version. |
There was a problem hiding this comment.
Suggested change
| The `R` section displays the R version. | |
| The `rlang` section displays the R version. |
docs/sections/R.md
Outdated
|
|
||
| | Variable | Default | Meaning | | ||
| | :-------------------- | :--------------------------------: | ------------------------------------------ | | ||
| | `SPACESHIP_R_SHOW` | `true` | Show section | |
There was a problem hiding this comment.
R -> RLANG
Suggested change
| | `SPACESHIP_R_SHOW` | `true` | Show section | | |
| | `SPACESHIP_RLANG_SHOW` | `true` | Show section | |
There was a problem hiding this comment.
Right, @denysdovhan. I'll do that.
In the meantime, can you have a look at other PR #1367?
denysdovhan
added
the
new-feature
|
Hey @denysdovhan, I have made the changes as you have suggested. |
denysdovhan
requested changes
Aug 1, 2023
sections/rlang.zsh
Outdated
| [[ $? -ne 0 || -z $R_version ]] && return | ||
|
|
||
| # Verbose output | ||
| [[ $SPACESHIP_R_VERBOSE == false ]] && R_version=$(echo $R_version | cut -d ' ' -f 1) |
There was a problem hiding this comment.
Suggested change
| [[ $SPACESHIP_R_VERBOSE == false ]] && R_version=$(echo $R_version | cut -d ' ' -f 1) | |
| [[ $SPACESHIP_RLANG_VERBOSE == false ]] && R_version=$(echo $R_version | cut -d ' ' -f 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for R lang.
Fixes #1224.
Screenshot