Fix package maven #1320
Open
Fix package maven #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spaceship-prompt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
merikan
force-pushed
the
fix_package_maven
branch
from
d83dab9
to
c14d732
Compare
denysdovhan
requested changes
Jan 30, 2023
| local maven_exe=$(spaceship::upsearch mvnw) || (spaceship::exists mvn && maven_exe="mvn") || return | ||
|
|
||
| $maven_exe help:evaluate -q -DforceStdout -D"expression=project.version" 2>/dev/null | ||
| local maven_exe=$(spaceship::upsearch mvnw || (spaceship::exists mvn && echo "mvn")) || return |
There was a problem hiding this comment.
This is a very complex line. Can we simplify that with a multi-line if-else?
There was a problem hiding this comment.
Sorry @denysdovhan I totally missed this. Sure, I can clean things up. 👍
There was a problem hiding this comment.
Not a problem. Waiting for your changes.
denysdovhan
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package maven module didn't handle non-parseable XML file (pom.xml). This could happen e.g. if you are in a middle of a merge-conflict. The maven command prints errors to stdout so we have to check the exit code.
When fixing non-parseable pom I discovered that we didn't handle the lookup for maven exe correctly so I fixed that too.
Added tests for package_maven.
Screenshot