Add search filter to the admin menu player tab #28030
Open
+230
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCommander
requested review from
DrSmugleaf and
Chief-Engineer
as code owners
github-actions
bot
added
Status: Needs Review
juliangiebel
approved these changes
May 23, 2024
Content.Client/Administration/UI/Tabs/PlayerTab/PlayerTab.xaml.cs
Outdated
Show resolved
Hide resolved
Chief-Engineer
approved these changes
May 23, 2024
1 task
github-actions
bot
added
the
Status: Needs Review
AJCM-git
approved these changes
May 31, 2024
| { | ||
| Title = $"{sel.CharacterName} / {sel.Username}"; | ||
| Title = "None selected"; |
| CharacterLabel.Text = player.CharacterName; | ||
| if (player.IdentityName != player.CharacterName) | ||
| CharacterLabel.Text += $" [{player.IdentityName}]"; | ||
| AntagonistLabel.Text = player.Antag ? "YES" : "NO"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a search bar filter that searches player name, character name, character identity, and character job.
Why / Balance
Technical details
Implements a new control called SearchListContainer that adds search functionality to a ListContainer.
Reworks the player tab to use SearchListContainer.
Fix PlayerListControl handling when the selected button is deleted.
Media
Content.Client_v4aJd0dIlv.mp4
Breaking changes
Changelog
Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑
ADMIN: