Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflow the player tab to show more of the names #28029

Merged
merged 2 commits into from
May 31, 2024
Merged

Reflow the player tab to show more of the names #28029

merged 2 commits into from
May 31, 2024
+8 −6

Conversation

ShadowCommander
Copy link
Member

About the PR

Changes the weights on the admin menu player tab columns so that the username and character name have more space.

Why / Balance

The other columns had a lot of blank space, while the names were cut off.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Old:
Content Client_X438Diqg1I
Content Client_CSLgW01M4h

New:
Content Client_PUNFrNhDxz
Content Client_D51HSobhtD

Breaking changes

Changelog

🆑
ADMIN

  • tweak: Tweaked the player tab column widths so that usernames and character names are more visible.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design No C# For things that don't need code. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels May 14, 2024
@AJCM-git AJCM-git merged commit 7e8e145 into space-wizards:master May 31, 2024
7 of 10 checks passed
@ShadowCommander ShadowCommander deleted the player-tab-width-reflow branch May 31, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chief-Engineer Chief-Engineer Chief-Engineer approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShadowCommander @Chief-Engineer @AJCM-git