Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ninja hacking not affecting sechud #28021

Merged
merged 1 commit into from
May 16, 2024

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented May 14, 2024

About the PR

hacking and changing status in the console now use the same code
refactoring too

Why / Balance

bug bad fixes #28013

Technical details

  • moved RecordName into station records system and made it public
  • moved criminal identity stuff from console to criminal records since it has nothing to do with the console
  • misc refactoring

Media

16:16:36

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
馃啈

  • fix: Fixed ninja criminal records hack not changing sechud icons.

@EmoGarbage404 EmoGarbage404 merged commit b453b94 into space-wizards:master May 16, 2024
12 checks passed
@deltanedas deltanedas deleted the sechud-ops branch May 16, 2024 22:33
Titian3 pushed a commit to Titian3/space-station-14 that referenced this pull request May 24, 2024
minor refactor and fix

Co-authored-by: deltanedas <@deltanedas:kde.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ninja criminal records sabotage does not add the icons
2 participants