Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed old snake_case IDs to PascalCase IDs #28014

Merged
merged 5 commits into from
May 14, 2024
Merged

Renamed old snake_case IDs to PascalCase IDs #28014

merged 5 commits into from
May 14, 2024

Conversation

Tunguso4ka
Copy link
Contributor

@Tunguso4ka Tunguso4ka commented May 14, 2024 •
edited

About the PR

  • Renamed soda dispenser ID from old snake_case to new PascalCase used in all other IDs. (no one touched it since soda dispenser creation)
  • Renamed chem master ID from old snake_case to new PascalCase used in all other IDs.
  • Added migration file

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

no 馃啈 no fun

@github-actions github-actions bot added the No C# For things that don't need code. label May 14, 2024
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label May 14, 2024
@Tunguso4ka Tunguso4ka changed the title Renamed soda_dispenser to SodaDispenser Renamed old snake_case IDs to PascalCase IDs May 14, 2024
@EmoGarbage404 EmoGarbage404 merged commit 9e8920c into space-wizards:master May 14, 2024
11 checks passed
@Tunguso4ka Tunguso4ka deleted the snake_case branch May 15, 2024 05:09
Titian3 pushed a commit to Titian3/space-station-14 that referenced this pull request May 24, 2024
@Tunguso4ka @Titian3
Renamed old snake_case IDs to PascalCase IDs (space-wizards#28014)
99bdc8d 
* Renamed soda_dispenser to SodaDispenser

* oops, wrong time

* oops

* guidebook

* chem_master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf DrSmugleaf approved these changes

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404 EmoGarbage404 is a code owner

Assignees
No one assigned
Labels
No C# For things that don't need code. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tunguso4ka @DrSmugleaf @EmoGarbage404