Modify battery assert to avoid floating point errors #28007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
does this fix that one wack ass assert that happens in debug or is this just like a preliminary thing |
This is just a wild guess at something that might fix it. I've been trying to reproduce it but its pretty inconsistent and I got tired of just having to leave stations running in the background. The one time I managed to reproduce it it had nonsensical values, in the sense that the assert tripped, but it shouldn't have been possible given the current values. |
|
Still happens for me pretty consistently after 2-5 minutes on the Dev map. |
Titian3
pushed a commit
to Titian3/space-station-14
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.