Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup duplicate stacking #27978

Merged

Conversation

ShadowCommander
Copy link
Member

About the PR

Makes duplicate popups stack on top of each other and add a x# at the end.

I didn't check super hard that it doesn't combine with another popup, but it should be ok, since all the values provided to popup are compared.

Why / Balance

This makes it possible to see what the message is when popups are spammed.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Content.Client_5zFYQmDePe.mp4

Breaking changes

Changelog

馃啈

  • tweak: Popups with the same message now stack together and append a x# to the end.

@DogZeroX
Copy link
Contributor

Holy sheet, we need this cjhat too! Nice pr

Content.Client/Popups/PopupSystem.cs Show resolved Hide resolved
Content.Client/Popups/PopupSystem.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label May 14, 2024
Copy link
Contributor

@AJCM-git AJCM-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it've cool if the popup grew a couple pixels until it reached a limit (twice its size or something) but if thats too hard/out of scope disregard

Content.Client/Popups/PopupSystem.cs Outdated Show resolved Hide resolved
@AJCM-git AJCM-git added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. and removed Status: Needs Review This PR requires new reviews before it can be merged. labels May 28, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels May 29, 2024
@AJCM-git AJCM-git merged commit 49982ac into space-wizards:master May 29, 2024
11 of 12 checks passed
@ShadowCommander ShadowCommander deleted the popup-duplicate-stacking branch May 29, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants