-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup duplicate stacking #27978
Merged
AJCM-git
merged 5 commits into
space-wizards:master
from
ShadowCommander:popup-duplicate-stacking
May 29, 2024
Merged
Popup duplicate stacking #27978
AJCM-git
merged 5 commits into
space-wizards:master
from
ShadowCommander:popup-duplicate-stacking
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Holy sheet, we need this cjhat too! Nice pr |
metalgearsloth
previously requested changes
May 14, 2024
github-actions
bot
added
the
Status: Needs Review
This PR requires new reviews before it can be merged.
label
May 14, 2024
AJCM-git
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it've cool if the popup grew a couple pixels until it reached a limit (twice its size or something) but if thats too hard/out of scope disregard
AJCM-git
added
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
and removed
Status: Needs Review
This PR requires new reviews before it can be merged.
labels
May 28, 2024
github-actions
bot
added
Status: Needs Review
This PR requires new reviews before it can be merged.
and removed
Status: Awaiting Changes
This PR needs its reviews addressed or changes to be made in order to be merged.
labels
May 29, 2024
AJCM-git
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Makes duplicate popups stack on top of each other and add a
x#
at the end.I didn't check super hard that it doesn't combine with another popup, but it should be ok, since all the values provided to popup are compared.
Why / Balance
This makes it possible to see what the message is when popups are spammed.
Technical details
Media
Content.Client_5zFYQmDePe.mp4
Breaking changes
Changelog
馃啈