Move some EntityCoordinates methods to TransformSystem
#5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
added
the
Status: Requires Content PR
|
Is it possible to do obsoletions? I really don't want to tank breaking changes here. |
ElectroJr
removed
the
Status: Requires Content PR
AFAIK I removed all the breaking changes, though content tests are still failing because of a new error log, but that was an existing error that just wasn't being caught before by tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has several miscellaneous changes for a content PR, including:
EntityCoordinatesmethods as obsolete and moves their logic toTransformSystemEntityCoordinatesmethodsBoundUserInterfaceMessageto theBoundUserInterfaceMessageAttemptevent, so that specific interactrions/messages can be given special treatment (e.g., opening the UI).ContainerSystemto take in optional transform components.BoundUserInterfaceCheckRangeEventso that it only gets raised directed and not broadcast. This is just to try slightly improve performance, because doing both will just be slower.Requires space-wizards/space-station-14/pull/27999