Hidden tiles #5102
Merged
Hidden tiles #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder how I should initialize this field in an object that is not in the engine? |
|
requires space-wizards/space-station-14#27666 |
PJB3005
requested changes
May 4, 2024
|
Done |
PJB3005
reviewed
May 4, 2024
| @@ -146,6 +146,8 @@ private void BuildTileList(string? searchStr = null) | |||
|
|
|||
| foreach (var entry in _shownTiles) | |||
| { | |||
| if (entry.EditorHidden) continue; | |||
There was a problem hiding this comment.
Didn't realize this on the first pass: it's probably better to do this filter before the name filter and sort, i.e. put it on line 133 with a .Where().
There was a problem hiding this comment.
Ok, but tomorrow. Im sleeping now
PJB3005
reviewed
May 16, 2024
Comment on lines
138
to
139
| (Loc.GetString(s.Name).Contains(searchStr, StringComparison.CurrentCultureIgnoreCase) || | ||
| s.ID.Contains(searchStr, StringComparison.OrdinalIgnoreCase)) && !s.EditorHidden); |
There was a problem hiding this comment.
Doing it like this only applies the hidden when you have a search string.
So there's no breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small addition that allows you to hide some tiles from the spawn menu. This is useful for downstrimes, disabling the ability to see standard tiles, but not causing huge problems with cutting them from everywhere they are used.