add SetUi to shared ui system #5092
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
metalgearsloth
requested changes
May 1, 2024
AJCM-git
reviewed
May 20, 2024
Comment on lines
+918
to
+919
| if (!Resolve(ent, ref ent.Comp, false)) | ||
| ent.Comp = AddComp<UserInterfaceComponent>(ent); |
There was a problem hiding this comment.
why not use the normal EnsureComp?
There was a problem hiding this comment.
if its cuz of the cursed Entity<> edge case, just do var comp = ensure(ent.Owner) and access it that way
There was a problem hiding this comment.
ensurecomp wont check if uid == comp.Owner i think, doing resolve does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evil refactor removed it