Compress large networked entity events #5027
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
holy fucking shit sensor monitoring console let's fricking go. |
PJB3005
requested changes
Apr 7, 2024
|
|
||
| namespace Robust.Shared.Network; | ||
|
|
||
| public abstract class CompressedNetMessage : NetMessage |
There was a problem hiding this comment.
This shouldn't be an abstract class at all, it only has some helper functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes networked
EntityEventArgsget automatically compressed if they are over 1024 bytes (game states currently get compressed above 256 bytes). This is probably useful for systems that consistently send easily compressible data (e.g., gas tile overlay), or just send large messages (e.g., some admin/debug overlays).I'm somewhat unsure about what to do in the case of multi-threaded message sending.
RaiseNetworkEventnow takes in an optionalZStdCompressionContext, so callers could use something like thePvsThreadResourcespool, but it defaults to using aThreadLocal<ZStdCompressionContext>.This PR also removes the
EntityMessageTypeenum, seeing as it was unused, and I'm not sure what it was event meant to be used for.