langserver: Support --with-expectations-path option #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this patch, many warnings/infos for the Steep project are suppressed on my VSCode. Before: After: Some warnings are still shown. But it must be helpful to typing gradually :-) Note: I noticed #468 had been filed after I created this patch. I'm unsure which is better to enable the "expectations" mode in the langserver. Please let me know if you feel other way is better. Thanks, |
tk0miya
commented
Aug 7, 2023
| @@ -41,12 +42,13 @@ def self.start_worker(type, name:, steepfile:, steep_command:, index: nil, delay | |||
| steep_command: steep_command || "steep", | |||
| index: index, | |||
| delay_shutdown: delay_shutdown, | |||
| patterns: patterns | |||
| patterns: patterns, | |||
| with_expectations_path: with_expectations_path | |||
There was a problem hiding this comment.
Note: I did not test the spawn_worker locally. How do I test this?
Add `--with-expectations=PATH` option to the langserver subcommand. It suppresses warnings and info messages using expectations file like check command does. And it helps to users to develop RBS files gradually.
tk0miya
force-pushed
the
with-expectations-path_for_langserver
branch
from
a19991c
to
809ec80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--with-expectations=PATHoption to the langserver subcommand. It suppresses warnings and info messages using expectations file like check command does. And it helps to users to develop RBS files gradually.