Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full gather results from plugin are not compatible with sourmash tax #330

Open
ctb opened this issue May 12, 2024 · 2 comments
Open

full gather results from plugin are not compatible with sourmash tax #330

ctb opened this issue May 12, 2024 · 2 comments

Comments

@ctb
Copy link
Collaborator

ctb commented May 12, 2024

Now that #298 was merged, we can in theory use the full gather results from fastgather and fastmultigather for taxonomy reporting with sourmash tax metagenome.

But... not so fast!

It looks like there are incompatibilities. I'm getting ERROR: Error: Cannot add TaxResult: query information does not match. when running (e.g.) sourmash tax metagenome -t ../sourmash/gtdb-rs214.lineages.sqldb -g srr.fg.csv.

I debugged it a little this morning - the QueryInfo comparison in is_compatible in tax/tax_utils.py seems to be failing.

I'm not sure how much of it is the different column names vs other things, but I think we need to resolve this before a release.

cc @bluegenes - no good deed goes unpunished 😆 😭

@bluegenes
Copy link
Contributor

Hmm, the changed cols are all match related, and this error looks like it's the related to the query columns (query_name, query_md5, query_bp, etc). All query columns should be identical for a single query, and should not reflect any subtraction we do during gather.

Can you select query cols and sort uniq to see if any change across the file? Or point me at your file? :)

@ctb
Copy link
Collaborator Author

ctb commented May 12, 2024

ref #331 also

just try to use the srr.fg.csv file in the repo https://github.com/ctb/2024-debug-gather-difference.

(gotta run, more later maybe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants