Fix cmake configure on Linux #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake still complains that there is no project() command. This commit was left over in my PR because of testing.
gynt
requested changes
Jan 28, 2023
| @@ -4,7 +4,7 @@ | |||
| using namespace Sourcehold; | |||
| using namespace System; | |||
|
|
|||
| static AVInputFormat *bink_input; | |||
| static AVInputFormat *bink_input const; | |||
There was a problem hiding this comment.
This throws an error:
/home/runner/work/Sourcehold/Sourcehold/src/FFMPEG/FFmpegUtil.cpp:7:33: error: expected ';' after top level declarator [clang-diagnostic-error]
static AVInputFormat *bink_input const;
There was a problem hiding this comment.
Maybe remove the const again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Mac specific stuff is included in the CMake dependency lists (namely the directives in
AddImportedTarget.cmake.This does not build on Linux, but it gets us through being able to do the initial configure.
Removing double colons from packages also silences a few warnings.