Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGM-6915 - Design revisions for the /demo/cody page #6925

Merged
merged 2 commits into from May 9, 2024
Merged

SGM-6915 - Design revisions for the /demo/cody page #6925

merged 2 commits into from May 9, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented May 8, 2024

This PR was created by GitStart to address the requirements from this ticket: SGM-6915.
This ticket was imported from: SGM-6915


Description:

Update cody demo page

Refs:

SG Issue
Gitstart ticket

Demo:
https://www.loom.com/share/3f7199427caa4fac84c22e135cc0413d?sid=657622dc-93d7-42e9-904a-c3ae12d38808

Copy link

netlify bot commented May 8, 2024

Deploy Preview for sourcegraph ready!

Name Link
🔨 Latest commit 1168159
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph/deploys/663cbf04e803a0000898ce3b
😎 Deploy Preview https://deploy-preview-6925--sourcegraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitstart-sourcegraph gitstart-sourcegraph self-assigned this May 8, 2024
@gitstart-sourcegraph gitstart-sourcegraph linked an issue May 8, 2024 that may be closed by this pull request
@iskyOS
Copy link
Contributor

iskyOS commented May 8, 2024

@gitstart-sourcegraph The video and splash screen are uploaded in GCP. Can we please load the files from GCP instead of adding them directly to the repo here? We'd prefer assets like the video to live in GCP instead of the repo

Here are the links:

Copy link
Contributor

@iskyOS iskyOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we load the video assets from GCP and remove from the repo?

@gitstart-app gitstart-app bot marked this pull request as draft May 8, 2024 20:47
@gitstart-sourcegraph gitstart-sourcegraph marked this pull request as ready for review May 9, 2024 12:19
Copy link
Contributor

@iskyOS iskyOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskyOS iskyOS merged commit 88f223b into main May 9, 2024
6 checks passed
@iskyOS iskyOS deleted the SGM-6915 branch May 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design revisions for the /demo/cody page
2 participants