Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous repository updates #1704

Merged
merged 6 commits into from May 6, 2024

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented May 6, 2024

  • Add documentation compile check to CI, as mentioned in fixing unicode errors in build: more fixes needed #1701 Completed in fixing unicode errors in build: more fixes needed #1701
  • Fix pull request template not working (add template similar the format in the frontend repo)
  • Reduce the pre-push hook run time (removed building and testing of code, as we have the CI to do that now) and instead only check format & linting.
  • Remove pre-commit hook as it is handled by the pre-push hook already. For users who are looking to keep their code well-formatted during coding, the use of IDE provided features will suffice.

@sayomaki sayomaki self-assigned this May 6, 2024
@sayomaki sayomaki requested a review from chownces May 6, 2024 08:30
.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 8967125626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.112%

Totals Coverage Status
Change from base Build 8966841125: 0.0%
Covered Lines: 10930
Relevant Lines: 12966

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 24c0aa3 into source-academy:master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants