Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the comment to link the specification #1680

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FYL2003
Copy link
Contributor

@FYL2003 FYL2003 commented Apr 16, 2024

The change is uploaded.

@FYL2003 FYL2003 linked an issue Apr 16, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8857707124

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.096%

Totals Coverage Status
Change from base Build 8857447014: 0.0%
Covered Lines: 10917
Relevant Lines: 12952

💛 - Coveralls

@@ -3361,6 +3369,10 @@ export function getEvaluationSteps(
[],
'Start of evaluation'
]
/**
* push the content into frontend for showing contents in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is not complete: "in the" ...

/**
* push the content into frontend for showing contents in the
* this comment may not be correct, please correct it if you find any mismatch in description
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment "this comment may not be correct" is quite strange. Are you referring to the one above: "push the content..."?

/**
* Deprecated check for empty program
* It can be deleted or kept as a reference for legacy code.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the check is deprecated, please delete it.

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit: the comments should be either

// line 1
// line 2

or /* ... */ multi-line comments, not /** .... */ documentation comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Adding comments for stepper.ts for easier understanding
4 participants