-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the comment to link the specification #1680
base: master
Are you sure you want to change the base?
add the comment to link the specification #1680
Conversation
Pull Request Test Coverage Report for Build 8857707124Details
💛 - Coveralls |
…ier-understanding
@@ -3361,6 +3369,10 @@ export function getEvaluationSteps( | |||
[], | |||
'Start of evaluation' | |||
] | |||
/** | |||
* push the content into frontend for showing contents in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is not complete: "in the" ...
/** | ||
* push the content into frontend for showing contents in the | ||
* this comment may not be correct, please correct it if you find any mismatch in description | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment "this comment may not be correct" is quite strange. Are you referring to the one above: "push the content..."?
/** | ||
* Deprecated check for empty program | ||
* It can be deleted or kept as a reference for legacy code. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the check is deprecated, please delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit: the comments should be either
// line 1
// line 2
or /* ... */
multi-line comments, not /** .... */
documentation comments.
…ier-understanding
…ier-understanding
The change is uploaded.