Dependency updates #62
Open
+11,007
−11,128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2023 09:27
Major bump for Hapi was basically just the CORS OPTIONS response change from 204 -> 200. TypeScript was just a couple of minor type fixes, mostly for updated types for node. BREAKING CHANGE: drop support for node 14.
We now need to support `import type` and multiple import lines, such
such that there can be an `import type { ...} from '...intervene'` and
a second `import { ... } from 'intervene'` line. This also meant we
could no longer rely on importing `ProxyConfig` as the confirmation
that this was indeed an intervene import line. So we now rely on there
only being intervene known imports in the statement _and_ that the word
`intervene` is somewhere in the import path.
Note that this is related to the TypeScript update, as TS4 introduces
`import type`.
Since the name change, we needed to update the hostname to the new vercel.app hostname for the tests, from github.com/bruderstein/intervene-test. Note that this still doesn't work against production, as the intervene-test project needs updating to run with the new vercel environment (was previous now.sh, which was renamed). But running the tests against that repo running locally works now
Test on 16,18,20
|
Tagging @pablofmena @lukehorvat :) |
pablofmena
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
lvgtm1 sorry for the late reply
@bruderstein Christmas visit ❤️
| @@ -1,4 +1,4 @@ | |||
| const REAL_EXTERNAL_HOST = 'https://intervene-test.bruderstein.now.sh'; | |||
| const REAL_EXTERNAL_HOST = 'https://intervene-test.bruderstein.vercel.app'; | |||
There was a problem hiding this comment.
what's served from here? are you planning on hosting it forever? 😅
| @@ -9,7 +9,7 @@ | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "prepare": "npm run build", | |||
| "build": "tsc -p . -d", | |||
| "build": "tsc -p . -d && cp src/brotli-decode.* dist/src", | |||
There was a problem hiding this comment.
does this serve as a replacement for https://github.com/soundcloud/intervene/blob/master/Makefile#L8? should we favor running the npm script directly over the make target?
lukehorvat
approved these changes
Dec 11, 2023
| @@ -17,15 +17,16 @@ export interface CertificateOptions { | |||
| const HOUR_IN_MS = 60 * 60 * 1000; | |||
| const DAY_IN_MS = 24 * HOUR_IN_MS; | |||
|
|
|||
| const certPromises: { [key: string]: Promise<tls.SecureContextOptions> } = {}; | |||
| const certPromises: { [key: string]: Promise<tls.SecureContextOptions> | undefined } = {}; | |||
There was a problem hiding this comment.
?
Suggested change
| const certPromises: { [key: string]: Promise<tls.SecureContextOptions> | undefined } = {}; | |
| const certPromises: { [key: string]?: Promise<tls.SecureContextOptions> } = {}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Hapi (to latest), TypeScript (to 4.x) and jest (to latest)
Fixed the import parser to match multiple import statements (useful if split between
importandimport type), and to also matchimport type ...statements.Dropped support for node 14 with Hapi 21.
Will do TypeScript 5.x separately.