Final 8.0 release prep #2606
Draft
Final 8.0 release prep #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is a draft because you intend to add other things, or in case we spot something that needs adding. Either way, changes in it as of now LGTM. |
|
It is a draft for both reasons, until the website stuff is done. Then I'll have to version-bump as part of the PR (because of those branch protection rules already mentioned). 馃榿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My own branch protection settings won't let me commit a quick fix directly to
master, so I guess I'll open a catch-all PR for this and any other stuff that was forgotten as part of #2600.Checklist
make qa(runsmake lintandmake test)