version: retrieve commit hash for git worktrees #2586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin and personal wish fulfillment. With this changeset, the
version
command will report commit information if Sopel is running from agit-worktree
.The current revision of the
version
plugin only supports reading commit information when the host Sopel is running inside of a 'real' git repository. I find it convenient to run Sopel from a worktree for a "near to development" copy, and it's nice to still have the commit information in this use-case.Checklist
make qa
(runsmake lint
andmake test
)mypy
becausetypes-urllib3
was not installed. I'm not sure if that's missing fromdev-requirements.txt
or if my local environment was in a weird state.test_example_suggest_*
caused by content decoding errors. I only vaguely recognize the issue, but I'm confident it's not this changeset's fault.