Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commandline: Add support for Non-Steam Games to getGameExe #969

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Nov 7, 2023

More work for #960.

This PR adds support for getting the Game EXE for Non-Steam Games. It returns in the same format, and can also search on game name. This also removes the need for the Non-Steam Game hack of setting the game EXE.

This shouldn't break Steam games either, all existing functionality should be untouched. This just adds support for Non-Steam Games, the same way #963 added support in gi and gt.

There is also a small refactor to those functions in this PR. We disable searching on shortcuts by default, to prevent any breakages when trying to search for unknown games names and erroneously falling back to shortcuts.vdf when we shouldn't. Searching on Non-Steam Games for these functions is only enabled when we're running from the commandline.

Side note: We don't write this out to the meta file, because the information in shortcuts.vdf is volatile, as the user can edit the game name or EXE at any time.


This PR is ready for merging after a version bump and some more testing.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Nov 8, 2023

Tested it when troubleshooting another issue, it should be ready to merge.

@sonic2kk sonic2kk merged commit b9a25c1 into master Nov 8, 2023
@sonic2kk sonic2kk deleted the nonsteam-get-exe branch November 8, 2023 00:40
@sonic2kk sonic2kk linked an issue Nov 8, 2023 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Non-Steam Game Improvements
1 participant