New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc: Bump Yad AppImage to use new release #1077
base: master
Are you sure you want to change the base?
Conversation
Bump Yad AppImage to use new release over at: https://github.com/sonic2kk/steamtinkerlaunch-tweaks/releases/tag/Yad-fbfb0fa-x86_64.AppImage
151d9e7
to
844287f
Compare
We can probably remove the duplicate |
The AppImage appears to work fine on my Linux PC. I don't have SteamTinkerLaunch on my Steam Deck, but I should be able to download and test the Yad AppImage standalone there sometime next week. Ideally before this gets merged, someone will test it out on SteamOS. |
Are you sure the AppImage downloaded correctly? It doesn't look like it did based on your terminal output. Double-check that the filesize is ~80mb. I was able to run it on my Steam Deck and it errored out around the glibc version. I'm guessing there's some glibc incompatibility between my Arch PC and the Steam Deck. SteamOS Sigh, I'll probably have to get a Debian VM or something to build against, assuming it has an older glibc version. Alternatively, this could wait until SteamOS updates to a newer glibc version. Hopefully with the next snapshot update this happens. |
You were right the file downloaded with curl was 0 bytes... Maybe we can compile it in a VM for Steamos or my idea of a CI will simplify this situation. |
Once again, I don't think CI is necessary. This also isn't an urgent change, Yad is not updated frequently. If needs be we can manage building it on an Ubuntu VM once every two years :-) |
Implements #1060.
Related #859.
Bump Yad AppImage to use new release over at: https://github.com/sonic2kk/steamtinkerlaunch-tweaks/releases/tag/Yad-fbfb0fa-x86_64.AppImage
We pin to the latest AppImage release on GitHub by assuming the release name and AppImage will have the same string. The new release should follow this convention. This means existing code and older releases will still use the old AppImage, but newer versions will download the new AppImage.
This new release updates the Yad version. As always on SteamOS, dependencies will have to be cleared to test this (the
steamtinkerlaunch cleardeckdeps
command).This PR needs significant amounts of testing before it can be merged. Once merged, the AppImage release will no longer be marked as a draft.