Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Bump Yad AppImage to use new release #1077

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Mar 24, 2024

Implements #1060.
Related #859.

Bump Yad AppImage to use new release over at: https://github.com/sonic2kk/steamtinkerlaunch-tweaks/releases/tag/Yad-fbfb0fa-x86_64.AppImage

We pin to the latest AppImage release on GitHub by assuming the release name and AppImage will have the same string. The new release should follow this convention. This means existing code and older releases will still use the old AppImage, but newer versions will download the new AppImage.

This new release updates the Yad version. As always on SteamOS, dependencies will have to be cleared to test this (the steamtinkerlaunch cleardeckdeps command).

This PR needs significant amounts of testing before it can be merged. Once merged, the AppImage release will no longer be marked as a draft.

@sonic2kk
Copy link
Owner Author

We can probably remove the duplicate YAIURL in setYadBin in this PR as well. There was a TODO left here about this since #1063, as it appears to be identical to the one found in uris.conf.

@sonic2kk
Copy link
Owner Author

The AppImage appears to work fine on my Linux PC. I don't have SteamTinkerLaunch on my Steam Deck, but I should be able to download and test the Yad AppImage standalone there sometime next week.

Ideally before this gets merged, someone will test it out on SteamOS.

@Mte90
Copy link
Contributor

Mte90 commented Mar 25, 2024

I am trying on SteamOS but doesn't happen anything.
In console I am getting nothing so I can't help..

immagine

@sonic2kk
Copy link
Owner Author

sonic2kk commented Mar 25, 2024

Are you sure the AppImage downloaded correctly? It doesn't look like it did based on your terminal output. Double-check that the filesize is ~80mb.

I was able to run it on my Steam Deck and it errored out around the glibc version. I'm guessing there's some glibc incompatibility between my Arch PC and the Steam Deck.


SteamOS glibc 2.38-3.2, that explains why it doesn't work as the AppImage on my PC was built against a newer glibc version.

Sigh, I'll probably have to get a Debian VM or something to build against, assuming it has an older glibc version. Alternatively, this could wait until SteamOS updates to a newer glibc version. Hopefully with the next snapshot update this happens.

@sonic2kk sonic2kk marked this pull request as draft March 25, 2024 18:59
@Mte90
Copy link
Contributor

Mte90 commented Mar 26, 2024

You were right the file downloaded with curl was 0 bytes...
I got the same error about glibc 2.38 and 2.34 not found.

Maybe we can compile it in a VM for Steamos or my idea of a CI will simplify this situation.

@sonic2kk
Copy link
Owner Author

Once again, I don't think CI is necessary. This also isn't an urgent change, Yad is not updated frequently.

If needs be we can manage building it on an Ubuntu VM once every two years :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants