[SFT-1074]: Hidden Group Field refactor to use db tables #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavs-gutmanis
requested changes
Apr 30, 2024
| )} | ||
| </GroupWrapper> | ||
| ))} | ||
| {data.groups.grouped?.map( |
There was a problem hiding this comment.
You should not have changed the front-end at all, all of this logic needs to be in the backend.
You previously returned hidden and groups in the response, this can still remain exactly like that, just pick the hidden fields out of the array in the backend.
gustavs-gutmanis
requested changes
Apr 30, 2024
Comment on lines
27
to
32
| if (!empty($hiddenTypes)) { | ||
| $groupRecord = new FieldTypeGroupRecord(); | ||
| $groupRecord->uid = 'hidden'; | ||
| $groupRecord->types = json_encode($hiddenTypes); | ||
| $groupRecord->save(); | ||
| } |
There was a problem hiding this comment.
Hmm, what if I have hidden groups set up already? Would this not trigger an error, saying that a record like this already exists?
Also I think using uid is not very safe, something might rely on all db rows using UUID v4.
How about using a record with handle freeform_hidden?
And before addinga new one, try to fetch one from the db by FieldTypeGroupRecord::findOne(['handle' => 'freeform_hidden']);
gustavs-gutmanis
previously approved these changes
Apr 30, 2024
thejahid
changed the title
gustavs-gutmanis
changed the title
gustavs-gutmanis
approved these changes
May 1, 2024
kjmartens
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket Number
SFT-1074
Description
Hidden Field Type group was saving data to the Freeform Settings model, and this caused issues for people using
allowAdminChanges => false, who then were not able to persist the changes for field groups.