k8s gateway extensions: allow customizing translator #9471
+127
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
|
Visit the preview URL for this PR (updated for commit 93867d8): https://gloo-edge--pr9471-stevenctl-allow-cust-x18vicvf.web.app (expires Thu, 30 May 2024 20:44:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
3 tasks
4 tasks
jenshu
reviewed
May 20, 2024
| // GetEnvoyImage returns the envoy image and tag used by the proxy deployment. | ||
| // GetTranslator allows an extnsion to provide custom translation for | ||
| // different gateway classes. | ||
| GetTranslator(*apiv1.Gateway) translator.K8sGwTranslator |
There was a problem hiding this comment.
should this take in the GatewayClass instead?
There was a problem hiding this comment.
It leaves some flexibility to look at labels/annotations if needed. I'm not sure further restricting it gives much of an advantage.
EItanya
reviewed
May 22, 2024
| // CreatePluginRegistry returns the PluginRegistry | ||
| CreatePluginRegistry(ctx context.Context) registry.PluginRegistry | ||
| // GetPluginRegistry exposes the plugins supported by this implementation. | ||
| GetPluginRegistry() registry.PluginRegistry |
There was a problem hiding this comment.
@jmhbh or @ilackarms would know better if this needs to be created every time, I don't think so but I defer to them.
EItanya
previously approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API changes
The only API is an internal code API to allow GME to take control of the Gateway translation.
Changed
CreatePluginRegistrytoGetPluginRegistry. AFAICT there is no need to recreate the registry each time but I can rever tthis if needed.Added:
GetTranslatorto allow conditionally switching the translation logic based on the type of gateway.Context
See slack conversation here