Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Introduce a validator to validate envoy configs #9465

Merged
merged 18 commits into from May 13, 2024
Merged

refactor: Introduce a validator to validate envoy configs #9465

merged 18 commits into from May 13, 2024

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented May 9, 2024 •
edited

Description

Refactor bootstrap.ValidateBootstrap() by moving the DisableTransformationValidation check into the transformation plugin. This way the bootstrap.ValidateBootstrap() can be used in other areas independent of this setting.
As of now it is called only in the transformation plugin so it is safe to make this change
Required for this enterprise PR

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 9, 2024
@davidjumani davidjumani force-pushed the refactor-transformation-validation branch from 7b8a988 to 4a09b62 Compare May 9, 2024 02:49
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

Visit the preview URL for this PR (updated for commit bbec022):

https://gloo-edge--pr9465-refactor-transformat-sqmrg10i.web.app

(expires Mon, 20 May 2024 13:44:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

sheidkamp
sheidkamp previously approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@sheidkamp sheidkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

sheidkamp
sheidkamp reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@sheidkamp sheidkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm thinking about the solo-projects PR a couple thoughts here.

projects/gloo/pkg/plugins/transformation/plugin.go Show resolved Hide resolved
projects/gloo/pkg/plugins/transformation/plugin.go Outdated Show resolved Hide resolved
@davidjumani davidjumani changed the title refactor: Make bootstrap.ValidateBootstrap independant of the DisableTransformationValidation setting refactor: Introduce a validator to validate envoy configs May 10, 2024
@davidjumani
Copy link
Contributor Author

kick bulldozer

@soloio-bulldozer soloio-bulldozer bot merged commit cbe51d0 into main May 13, 2024
23 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the refactor-transformation-validation branch May 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheidkamp sheidkamp sheidkamp approved these changes

@nfuden nfuden nfuden approved these changes

Assignees
No one assigned
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidjumani @sheidkamp @nfuden