suggestion: use kube-builder for ggv2 crds #9347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
yuval-k
force-pushed
the
yuval-k/kube-builder-for-crds
branch
from
806367d
to
be9d53c
Compare
sam-heilbron
added
work in progress
|
Visit the preview URL for this PR (updated for commit c76f96b): https://gloo-edge--pr9347-yuval-k-kube-builder-hxx94ujz.web.app (expires Thu, 23 May 2024 19:17:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestion: use kube-builder for CRD generation.
pros: Kube builder generation is simpler, faster, and has more features than skv2 CRD generation.
cons: need to figure out docs integration