DO NOT MERGE Expose disable dynamic stats (#9260) #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Very rough implementation before protogen * Run `make generate-all`. https://xkcd.com/499/ * Regenerate code with correct version of protoc * Cleaner implementation of setting dynamic_stats * Add a test to set both options on the router dynamic_stats and suppress_envoy_headers can both be set in this test * Clean up the unit tests in a big way * A little more clean-up * Update changelog * Update changelog wording * Move router tests to separate file * Remove more redundant code in the table tests * Remove focus * Add TODO to address creating a new router plugin * Re-run codegen * Use HttpListener translator and fix table name --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
github-actions
bot
added
the
keep pr updated
sam-heilbron
added
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rough implementation before protogen
Run
make generate-all. https://xkcd.com/499/Regenerate code with correct version of protoc
Cleaner implementation of setting dynamic_stats
Add a test to set both options on the router
dynamic_stats and suppress_envoy_headers can both be set in this test
Clean up the unit tests in a big way
A little more clean-up
Update changelog
Update changelog wording
Move router tests to separate file
Remove more redundant code in the table tests
Remove focus
Add TODO to address creating a new router plugin
Re-run codegen
Use HttpListener translator and fix table name
Description
Please include a high level summary of the changes.
This bug fixes ... \ This new feature can be used to ...
Fill out any of the following sections that are relevant and remove the others
API changes
Code changes
Foo()functionBar()functionCI changes
Docs changes
Context
Users ran into this bug doing ... \ Users needed this feature to ...
See slack conversation here
Interesting decisions
We chose to do things this way because ...
Testing steps
I manually verified behavior by ...
Notes for reviewers
Be sure to verify intended behavior by ...
Please proofread comments on ...
This is a complex PR and may require a huddle to discuss ...
Checklist: