Make props argument optional

[duckradu]

The signature for the Directive doesn't allow it to be used as a ref as shown in the docs. If the props are optional then the function signature matches.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c538e02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[thetarnav]

I don’t think you’re using the type correctly.
ref is not a directive.

[duckradu]

I was following the example from the docs - https://primitives.solidjs.community/package/pagination#createinfinitescroll

[thetarnav]

ah nvm I get it
I have to think about it
Making it optional hurts the proper usage

[thetarnav]

this? use:infiniteScrollLoader?

[duckradu]

The docs show that it can be used both as a directive and ref:

(feel free to dm me on discord if it's easier to chat there)

[thetarnav]

It looks like it shouldn’t be typed as a directive if it is meant to be used with both ref and as a directive. because it just doesn’t use the second arg at all.

[duckradu]

Would a new custom type be okay in that case? Something like ElementInstance or idk, which basically has the signature of a ref, but could be used as a Directive as well when the props are not relevant

[thetarnav]

no need to make it a generic helper. createInfiniteScroll just should be typed correctly.

[duckradu]

Something like this?

[thetarnav]

yes although there is no need in making it generic
I think loader: (el: Element) => void would be enough

[duckradu]

Done! Want me to update this PR or should I just close it?

[thetarnav]

It seems that this PR is about something completely different now?
Can you make a separate PR for the changes that are changing the API, and leave only the type-fix here?