Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dirs-first with dir-order #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xiuxiu62
Copy link

This replaces dirs-first with a dir-order option, for ordering directory nodes in branch arms before or after other inodes. It makes some simplifications to how comparators are generated and applied to sort passes on inodes.

Sorry for jumbling this up with another pr. Let me know if you'd like me to make any updates.

@xiuxiu62 xiuxiu62 changed the title Add dir precedence Replace dirs-first with dir-order Mar 14, 2023
@solidiquis
Copy link
Owner

Hey @xiuxiu62 thanks for taking an interest! Unfortunately I've decided to move forward with #67 mainly because your change would break backwards compatibility, therefore necessitating either a major version bump or a deprecation process leading to an eventual major version bump. I do, however, like the simplification of how comparators are treated so I'd be happy to have that as a separate PR. Let me know your thoughts.

@xiuxiu62
Copy link
Author

Completely understand, no worries. I'm not sure it makes sense to change the comparator implementation, unless there are more client options that can be used to produce a comparator. It got a little hairy dealing with the move semantics of multiple comparators when you have more than one branching source, but with just the SortType and dirs-first bool, the original implementation works great. I'd be happy to work on a separate PR though, if it would be beneficial for the project moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants