extensions/chm_serviceonly.c: only allow service users to join #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesopo
commented
Jun 16, 2022
| static int | ||
| _modinit(void) | ||
| { | ||
| mymode = cflag_add('X', chm_staff); |
There was a problem hiding this comment.
placeholder character, please suggest better options
jillest
reviewed
Jun 18, 2022
| struct Client *source_p = data->client; | ||
| struct Channel *chptr = data->chptr; | ||
|
|
||
| if((chptr->mode.mode & mymode) && !IsService(source_p)) { |
There was a problem hiding this comment.
There is no way a local client can be a service, so the && !IsService(source_p) part could be removed.
This feels weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intended usecase is to allow for channels that are IPC between atheme and a pseudoserver; this may be too niche for upstream