Refactor remove unnecessary rounding #34963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34963 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 224746 224757 +11
=======================================
+ Hits 183512 183533 +21
+ Misses 41234 41224 -10 |
tao-stones
force-pushed
the
refactor-remove-rounding
branch
from
09f44c4
to
f734de4
Compare
apfitzge
reviewed
Jan 26, 2024
| .saturating_add(write_lock_fee) | ||
| .saturating_add(compute_fee) as f64) | ||
| .round() as u64, | ||
| .saturating_add(compute_fee), |
There was a problem hiding this comment.
needs a feature-gate 😢 f64 rounding could lead to a different result here if total fee is high....I think that this probably would not happen practically
There was a problem hiding this comment.
I guess safe to 2^53...so practically is this okay?
|
Close it for now, issue ##34982 tracks it. Removing round() needs a feature gate, which requires an additional parameter to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A call to
round()was left behind after removing congestion_multipler.Summary of Changes
Fixes #