Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): graphql: token-2022 extensions: DepositConfidentialTransfer #2652

Merged
merged 3 commits into from
May 6, 2024

Conversation

nasjuice
Copy link
Contributor

@nasjuice nasjuice commented May 6, 2024

This PR adds support for Token-2022's DepositConfidentialTransfer instruction in the GraphQL schema.

Continuing work on #2406.

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: 4a1a677

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label May 6, 2024
@mergify mergify bot requested a review from a team May 6, 2024 20:22
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one nit.

packages/rpc-graphql/src/schema/instruction.ts Outdated Show resolved Hide resolved
@nasjuice
Copy link
Contributor Author

nasjuice commented May 6, 2024

Sounds good, changed it

I was a bit confused some places had these FIXME
image

Now it makes sense, I guess they are meant to be refactored to Int

Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groovy

@buffalojoec
Copy link
Collaborator

I was a bit confused some places had these FIXME

Ahh wait, sorry, good call here. Web3.js 2.0 will turn those to bigint. Mind flipping it back, and adding the "FIXME" comment?

Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking this as non-approved until the decimals fix. Nice catch on that!

@nasjuice
Copy link
Contributor Author

nasjuice commented May 6, 2024

Sounds good, fixed now

Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, ship it!

@buffalojoec buffalojoec merged commit 533bcae into solana-labs:master May 6, 2024
6 checks passed
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants