Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): graphql: token-2022 extensions: TransferCheckedWithFee #2578

Conversation

Hrushi20
Copy link
Contributor

@Hrushi20 Hrushi20 commented Apr 27, 2024

This PR adds support for Token-2022's TransferFeeExtension's TransferCheckedWithFee instruction
in the GraphQL schema.

Continuing work on #2406.

Copy link

changeset-bot bot commented Apr 27, 2024

⚠️ No Changeset found

Latest commit: b600970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot added the community label Apr 27, 2024
@mergify mergify bot requested a review from a team April 27, 2024 17:23
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Left a few comments.

packages/rpc-graphql/src/__tests__/transaction-tests.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have to rebase onto my latest merges, but looks great! Thanks!

@buffalojoec buffalojoec changed the title graphql: token-2022 extensions: TransferCheckedWithFee refactor(experimental): graphql: token-2022 extensions: TransferCheckedWithFee May 2, 2024
@Hrushi20 Hrushi20 force-pushed the feature-configureConfidentialTransferAccount branch from de159a2 to b600970 Compare May 4, 2024 14:41
@Hrushi20
Copy link
Contributor Author

Hrushi20 commented May 4, 2024

This can be merged.

@buffalojoec buffalojoec merged commit 1cd7cb4 into solana-labs:master May 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants