refactor(experimental): graphql: relay: Add support for id field in transactions

[tibi77]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6ff09fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[buffalojoec]

Cool, so this is the right first step, but our GraphQL client doesn't actually know how to populate that field. You'll need to hook that into the resolver here.

solana-web3.js/packages/rpc-graphql/src/resolvers/transaction.ts

Lines 105 to 108 in 35aed3c

	let result: TransactionResult = {
	encodedData: {},
	signature,
	};

[tibi77]

Cool, so this is the right first step, but our GraphQL client doesn't actually know how to populate that field. You'll need to hook that into the resolver here.

solana-web3.js/packages/rpc-graphql/src/resolvers/transaction.ts

Lines 105 to 108 in 35aed3c

	let result: TransactionResult = {
	encodedData: {},
	signature,
	};

should i be adding the ID inside the buildTransactionLoaderArgSetFromResolveInfo as well?

solana-web3.js/packages/rpc-graphql/src/resolvers/resolve-info/transaction.ts

Lines 79 to 88 in 35aed3c

	export function buildTransactionLoaderArgSetFromResolveInfo(
	args: {
	commitment?: Omit<Commitment, 'processed'>;
	minContextSlot?: Slot;
	signature: Signature;
	},
	info: GraphQLResolveInfo,
	): TransactionLoaderArgs[] {
	return buildTransactionArgSetWithVisitor(args, info);
	}

[buffalojoec]

should i be adding the ID inside the buildTransactionLoaderArgSetFromResolveInfo as well?

Technically, that's not necessary for cache matching - since we're using another field for that - but to follow the expected Relay pattern I guess we should also include the ID.

[tibi77]

@buffalojoec I m trying to test locally the tests that are failing inside the pipeline, but i not getting same fails

npm -v; pnpm -v
9.8.1
9.0.6

is it just because of the node versions? Or am i missing something else when i run the tests?

node -v
v18.18.2

i do run

 pnpm build --concurrency=100%

which seems to be the one that fails

[buffalojoec]

@buffalojoec I m trying to test locally the tests that are failing inside the pipeline, but i not getting same fails

npm -v; pnpm -v
9.8.1
9.0.6

is it just because of the node versions? Or am i missing something else when i run the tests?

node -v
v18.18.2

i do run

 pnpm build --concurrency=100%

which seems to be the one that fails

I tend to get some flakiness from the main pnpm turbo run build command. But you definitely want to be using Node 20.

Try doing the following, and then running the tests only for the GraphQL library.

pnpm turbo clean
rm -rf node_modules
pnpm i
pnpm turbo compile:js compile:typedefs --force
cd packages/rpc-graphql
pnpm run test:unit:node

[buffalojoec]

@tibi77 any luck with the commands I shared?

[buffalojoec]

Hey @tibi77 I appreciate the contribution here, but I'm taking the Relay effort to a new branch feature/graphql-relay, and I've added the ID fields. Thanks!

Keep an eye on the issues if you want to keep hacking.