refactor(experimental): add function to check if a transaction is fully signed #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
mcintyre94
force-pushed
the
add-assert-fully-signed-tx
branch
from
10bd69c
to
193b243
Compare
buffalojoec
reviewed
Oct 25, 2023
mcintyre94
force-pushed
the
add-assert-fully-signed-tx
branch
from
193b243
to
e61e916
Compare
|
Yep good shout! Added this: // assertTransactionIsFullySigned
const transaction = {} as Parameters<typeof assertTransactionIsFullySigned>[0];
// @ts-expect-error Should not be fully signed
transaction satisfies IFullySignedTransaction;
assertTransactionIsFullySigned(transaction);
transaction satisfies IFullySignedTransaction; |
steveluscher
approved these changes
Oct 25, 2023
| requiredSigners.forEach(address => { | ||
| if (!transaction.signatures[address]) { | ||
| // TODO coded error | ||
| throw new Error(`Transaction is missing signature for address ${address}`); |
There was a problem hiding this comment.
Can I be annoying and ask for this in nice copy-pastable markdown format?
Suggested change
| throw new Error(`Transaction is missing signature for address ${address}`); | |
| throw new Error(`Transaction is missing signature for address \`${address}\``); |
lorisleiva
approved these changes
Oct 26, 2023
…ly signed - asserts that there is a signature for each expected signer - only verifies the presence of signatures, does not verify the signatures are valid
mcintyre94
force-pushed
the
add-assert-fully-signed-tx
branch
from
e61e916
to
3d321d0
Compare
|
🎉 This PR is included in version 1.87.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1773, but won't close yet in case we want to add a separate function to validate signatures too