[transfer-hook] Remove deprecated functions from cli #6525
Conversation
There was a problem hiding this comment.
Thanks for the contribution! Everything looks good to me, but I did make a mistake in the deprecation message for is_valid_signer in a previous PR. SignerSourceParserBuilder::default().build() does not actually accept any signer source kind. is_valid_signer should instead be replaced with SignerSourceParserBuilder::default().allow_all().build() instead. I made a PR to fix this anza-xyz/agave#531. Let's make the changes below and then I will approve the PR (I think is_valid_pubkey -> allow_pubkey().allow_file_path().build() is fine here). Thanks!
token/transfer-hook/cli/src/main.rs
Outdated
| @@ -209,7 +205,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| Arg::new("fee_payer") | |||
| .long("fee-payer") | |||
| .value_name("KEYPAIR") | |||
| .validator(|s| is_valid_signer(s)) | |||
| .value_parser(SignerSourceParserBuilder::default().build()) | |||
There was a problem hiding this comment.
| .value_parser(SignerSourceParserBuilder::default().build()) | |
| .value_parser(SignerSourceParserBuilder::default().allow_all().build()) |
|
Oh and it would be great to update #6526 to change |
Removed the deprecated functions from the transfer-hook cli as per #6307