token 2022: add GroupMemberPointer extension
#5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 22, 2023
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
from
c28bc25
to
e52e102
Compare
buffalojoec
force-pushed
the
10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface
branch
3 times, most recently
from
6a54e00
to
818d2b5
Compare
buffalojoec
force-pushed
the
10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface
branch
4 times, most recently
from
bf04d1b
to
65ac100
Compare
buffalojoec
added
the
do-not-close
buffalojoec
force-pushed
the
10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface
branch
from
65ac100
to
3cf8ea8
Compare
buffalojoec
changed the base branch from
10-18-token_2022_add_UpdateGroupAuthority_instruction_from_SPL_Token_Group_interface
to
11-14-token_2022_add_support_for_additional_signers_in_test_init_functions
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
from
e52e102
to
5f3942d
Compare
This was referenced Nov 14, 2023
buffalojoec
force-pushed
the
11-14-token_2022_add_support_for_additional_signers_in_test_init_functions
branch
from
65c5fbd
to
6320eb8
Compare
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
2 times, most recently
from
bbd4c02
to
c9ec232
Compare
buffalojoec
commented
Nov 16, 2023
There was a problem hiding this comment.
Ok @joncinque this should be ready for another look. Thanks for the previous review! RIP to repeating extensions 🪦
joncinque
reviewed
Nov 17, 2023
token/program-2022/src/extension/group_member_pointer/instruction.rs
Outdated
Show resolved
Hide resolved
token/program-2022/src/extension/group_member_pointer/instruction.rs
Outdated
Show resolved
Hide resolved
token/program-2022/src/extension/group_member_pointer/processor.rs
Outdated
Show resolved
Hide resolved
|
@joncinque considering the discussion here I'm going to re-work this PR and remove the group auth stuff. |
|
Done. Note I deleted the prior branch in the stack, so I re-wrote the commit here. |
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
from
24cb26a
to
d674818
Compare
buffalojoec
changed the base branch from
11-14-token_2022_add_support_for_additional_signers_in_test_init_functions
to
master
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
3 times, most recently
from
cb4de48
to
106a697
Compare
joncinque
reviewed
Nov 27, 2023
buffalojoec
force-pushed
the
10-22-token_2022_add_GroupMemberPointer_extension
branch
from
106a697
to
fbcb302
Compare
buffalojoec
deleted the
10-22-token_2022_add_GroupMemberPointer_extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
GroupMemberPointerextension to Token2022.This extension behaves exactly like the existing
GroupPointerextension, serving to denote the corresponding account containing a mint's group member configurations and prevent any unauthorized configurations.