Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade uWebSockets.js to support Node 20 #1105

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

iBotPeaches
Copy link

This is a good backward compatible change that adds support for an upgraded uWebSockets.js version. That upgrade gives us support for Node 20 - https://github.com/uNetworking/uWebSockets.js/releases/tag/v20.33.0

However, reading that you can see that uWebSockets.js isn't exactly happy with the LTS version. So very soon the only supported versions will be (18, 20, 21, 22), then (20, 22, 23, 24)

So this paired with: #1104 - I recommend a dual testing CI pipeline of Node 18 / 20. As Node LTS come out and you follow the guidelines of uWebSockets.js - then you'll end up dropping 16 (now), then 18 (next year), then 20 over the course of the newt few years.

Copy link

codeautopilot bot commented Jan 11, 2024

PR summary

The Pull Request updates the uWebSockets.js dependency to version v20.39.0 to add support for Node.js version 20. This change is backward compatible and aligns with the release notes of uWebSockets.js which indicate future support for Node.js versions 18, 20, 21, and 22, with subsequent versions to follow. The PR suggests implementing a dual testing CI pipeline for Node.js versions 18 and 20 to ensure compatibility with future Node.js LTS releases and adherence to uWebSockets.js guidelines.

Suggestion

The PR seems well-structured and follows the necessary upgrade path for Node.js compatibility. However, it would be beneficial to ensure that all other dependencies are compatible with Node.js version 20 to prevent any unforeseen issues. Additionally, it may be prudent to add automated tests or checks that can alert the team when a Node.js version is nearing its end of life or when a new LTS version is released, to streamline the upgrade process in the future.

Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect.

Current plan usage: 70.50%

Have feedback or need help?
Discord
Documentation
support@codeautopilot.com

@rennokki rennokki added status:active Active and working on it priority:critical Must be fixed ASAP goal:enhancement New feature or request labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:enhancement New feature or request priority:critical Must be fixed ASAP status:active Active and working on it
Development

Successfully merging this pull request may close these issues.

None yet

2 participants