-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented read #1
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Hi Andreas, I've implemented the read() part of the SerialIndex. I pulled out the data processing code into IO.cpp and IO.hpp and added The implementation most likely doesn't completely match what you want but can be adjusted fairly easily. For example, keys right now requires all of the characters to be alphabets and arrays aren't bound-checked because it doesn't store user's array information right now as I wanted to do as much as possible before having to allocate new memory. Also at the moment, it validates the input before actually evaluating and setting values which means it goes through the value part of the data twice. It prevents user from mistakenly set only part of an array but if that's okay then I could get rid of it so it only has to go through the value part of the data once. I implemented the ability to set array values partially which I call a There is no heap memory used during the data processing so the only heap memory allocation operations are inside the constructor. The code could use some DRYing up as there are a lot of pretty much identical code structures but I just keep it that way for now until we've finalized on the specifications so it's easier to change in case there's some special cases that need to be handled. Anyway, there's still some stuff to do like bounds-checking but I believe the concept and implementation is there. |
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
…me structure as the rest Signed-off-by: Jacky Boen <aqiank@gmail.com>
…ket right away Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
awesome jacky, lets meet soon to discuss details and then merge. |
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Jacky Boen <aqiank@gmail.com>
Just getting familiar with the source code :)
Signed-off-by: Jacky Boen aqiank@gmail.com
This change is