Add Source <> InputStream operations and chunks #134
Conversation
| true | ||
| } | ||
| catch | ||
| case t: Throwable => |
There was a problem hiding this comment.
ah no sorry 🤦 stream operators catch IE on purpose ... as these are propagated downstream. I discover this not the first time, I just need to document it somewhere visible ... ;)
There was a problem hiding this comment.
This, and also I copied that from your code :) softwaremill/sttp#2158
There was a problem hiding this comment.
hehe yes, well, it just shows it's not that intuitive ;)
core/src/main/scala/ox/Chunk.scala
Outdated
| /** An immutable finite indexed sequence of elements, backed by Array. Raw rrays are expensive performance-wise when you want to do | ||
| * operations like concatenation, splitAt, drop, etc. Such operations are often useful when doing Source processing. `Chunk` offers a | ||
| * wrapper focused primarly on performance optimizations for such costly operations, while maintaining familiar API of an `IndexedSeq`. | ||
| * Underneath, a `Chunk` should leverage lazy data structures to avoid unnecessary data copying, which is a typical drawback for most Array |
There was a problem hiding this comment.
it does? it looks like a wrapper on an array, are there any optimizations in palce?
There was a problem hiding this comment.
There are no optimizations yet, that's why I wrote that it "should" use these optimizations. I intended this PR to expose the Chunk API but start with simple non-optimized array operations. It can then later evolved as needed.
There was a problem hiding this comment.
Ok, sounds good, let's just explicitly write that: Chunk for now is a think wrapper on arrays, in the future we want to optimize its operations
|
Thanks :) Can you add follow-up tasks to (a) optimize the chunks, (b) add more input/output methods, I think reading/writing to/from |
|
Chunk task: #136
|
Yes, or just source.toOutputStream(OutputStream), same as you might have source.toFile(File) (or Path). We could also write a
I guess But let's open the tasks, we can discuss there further. |
|
Thanks :) Ok, we'll need to document this properly then. |
No description provided.