Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve XSS vulnerability #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolve XSS vulnerability #102

wants to merge 1 commit into from

Conversation

zanothis
Copy link

@zanothis zanothis commented Oct 14, 2021 •
edited

Fixes #43, #96

@zanothis zanothis changed the title sec(handlersUtil.js): Fix #43, #96 Resolve XSS vulnerability Oct 14, 2021
@softvar
Copy link
Owner

softvar commented Dec 9, 2021

Hey @zanothis ,
Thanks for your contribution.

Could you please explain the changes and how they solve the XSS vulnerability?

@zanothis
Copy link
Author

zanothis commented Dec 9, 2021

#43 & #96 were caused because the file names started with a " which allows for constructing a filename like "><iframe src="...">.png resulting in an iframe being injected into the page. By using encodeURIComponent, the filename is transformed into a safe string to be injected into the download attribute.

@PedroHase
Copy link

@softvar any news on this? Or has the vulnerability been fixed somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XSS vuln
4 participants
@zanothis @softvar @PedroHase @nebenjamin